Welcome!

Welcome to Satlover forums, full of great people, ideas and excitement.

Please register if you would like to take part. link..

Register Now

Alert: Don't Use Hotmail Email Accounts for registration

Collapse

Before Access to all Forums and Trial accounts you must need to activate your account Email address

Site bug from long time at least 07.01.2011

Collapse
X
 
  • Time
  • Show
Clear All
new posts
  • Jerry2020
    Banned
    • Feb 2010
    • 221

    Site bug from long time at least 07.01.2011

    If you open a topic in the forum, you find:
    0){document.location.href='showthread.php?p='+cpos tno;};} }">
    After ****** ads and before the topic.
    I use firefox.
  • khalidomar
    Board Senior Member
    • Jun 2010
    • 317

    #2
    Re: Small bug

    Yup, I believe this is a known issue to the admins and mods. I remember someone else raised the same issue before the last crash. I wonder why is it still there?!!

    I do have excellent programming knowledge and I'm welling to help the admins if needed to resolve this issue... just let me know
    Some Useful Posts

    sigpic

    Comment

    • peremacedonia
      Experienced Board Member
      • Jun 2010
      • 872

      #3
      Re: Small bug

      Its 2 minutes job only
      Rule n.33 kid..... Concentrate

      Comment

      • khalidomar
        Board Senior Member
        • Jun 2010
        • 317

        #4
        Re: Small bug

        Originally posted by peremacedonia
        Its 2 minutes job only

        Yup, that is what i think, but it has been there for almost a year or more! It is part of the culture now
        Some Useful Posts

        sigpic

        Comment

        • peremacedonia
          Experienced Board Member
          • Jun 2010
          • 872

          #5
          Re: Small bug

          Originally posted by khalidomar
          Yup, that is what i think, but it has been there for almost a year or more! It is part of the culture now
          I dont notice that code anymore.......
          no no is still there
          however .......
          Rule n.33 kid..... Concentrate

          Comment

          • uttnls

            #6
            Site bug from long time at least 07.01.2011

            Look on the C lines page you'll see that is an echo probably from PHP.

            I saw it for a long time, and not being fixed i want to bring it to your attention.

            For example on this page :



            You can see this chunck of code :

            0){document.location.href='showthread.php?p='+cpos tno;};} }">

            Like i said it looks to me like a javacode that is after ?>

            Or a wrong echo or something, anyway from source code you can figured out more easly, then me seeing only the HTML
            output

            If you look closely this string apears at thread level on the entire site

            Comment

            • sonc
              Experienced Board Member
              • Jun 2010
              • 1568

              #7
              Re: Site bug from long time at least 07.01.2011

              Its been there a lot longer than that

              It was mentioned last August:



              I don't even notice it any more

              Comment

              • uttnls

                #8
                Re: Site bug from long time at least 07.01.2011

                Originally posted by sonc
                Its been there a lot longer than that

                It was mentioned last August:



                I don't even notice it any more
                Thanks i've tried to search for "bug" on this thread and i couldn't find anything so i assumed it was not posted before.

                It is not a vulnerability but it could get fixed quite easly

                Comment

                • os2222
                  Senior Member
                  • Jan 2011
                  • 175

                  #9
                  Re: Site bug from long time at least 07.01.2011

                  seems like some thread counter (tno) in javascript as mentioned.
                  wrong php echo output. shouldnt harm anything but is ugly to watch every time ^^

                  Comment

                  • uttnls

                    #10
                    Re: Site bug from long time at least 07.01.2011

                    Originally posted by os2222
                    seems like some thread counter (tno) in javascript as mentioned.
                    wrong php echo output. shouldnt harm anything but is ugly to watch every time ^^
                    It is for an websites developers, it won't bother usual users, most of them i bet won't even observe it

                    Bytheway the problems comes from SEO module, is a common bug in VbSEO 3.3.0

                    Lots of users complain that after upgrading VbSeo from version 3.2.0 to VbSeo 3.3.0 they encountered this error "0){document.location.href='showthread.php?p='+cpo stno;};} }">".

                    Also this error is comming in conjunction with use of a custom template, not that provided with vbulletin.

                    As far i can see satlover uses vbseo 3.3.0 and that's why i'm sure that the error is from there.

                    Hope this will help in removing the bug

                    Comment

                    • peremacedonia
                      Experienced Board Member
                      • Jun 2010
                      • 872

                      #11
                      Re: Site bug from long time at least 07.01.2011

                      It was thread for this last sumer and it isnt fix yet so we need only to ignore thats leters
                      Rule n.33 kid..... Concentrate

                      Comment

                      • pirrup
                        Member
                        • Jun 2011
                        • 46

                        #12
                        Re: Small bug

                        the bug is still there , just got it after making a new thread

                        0){document.location.href='showthread.php?p='+cpos tno;};} }">

                        Comment

                        • enes
                          Senior Member
                          • Jun 2010
                          • 127

                          #13
                          Re: Small bug

                          Satlover, couple times try to find this extra code, with no luck. Maybe it's 2 minutes job, or couple minutes, but we cannot get access data to server and AdminCP forum to fix it. Maybe Satlover don't have enough time to deal with this?

                          Comment

                          • uttnls

                            #14
                            Re: Small bug

                            Is an vbulletin issue in conjunction with SEO module, and is not a problem easy fixable. Please do a ****** search and you'll see what is that about.

                            Look below, i also merged to threads on same issue and there is an older response of mine

                            Comment

                            • enes
                              Senior Member
                              • Jun 2010
                              • 127

                              #15
                              Re: Site bug from long time at least 07.01.2011

                              Originally posted by uttnls
                              It is for an websites developers, it won't bother usual users, most of them i bet won't even observe it

                              Bytheway the problems comes from SEO module, is a common bug in VbSEO 3.3.0

                              Lots of users complain that after upgrading VbSeo from version 3.2.0 to VbSeo 3.3.0 they encountered this error "0){document.location.href='showthread.php?p='+cpo stno;};} }">".

                              Also this error is comming in conjunction with use of a custom template, not that provided with vbulletin.

                              As far i can see satlover uses vbseo 3.3.0 and that's why i'm sure that the error is from there.

                              Hope this will help in removing the bug

                              It seems that you're right. This error code is in file:

                              INCLUDES/functions_vbseo_hook.php

                              Here is a error code, and now just to find where is a problem.

                              PHP Code:
                              case 'showthread_complete':
                              global 
                              $onload;
                              if(!
                              $onload && !strstr($_SERVER['HTTP_REFERER'],$_SERVER['VBSEO_URI']))
                              {
                              $onload "var cpost=document.location.hash;if(cpost){ if(cobj = fetch_object(cpost.substring(1,cpost.length)))cobj.scrollIntoView(true);else {cpostno = cpost.substring(5,cpost.length);if(parseInt(cpostno)>0){document.location.href='showthread.php?p='+cpostno;};} }";


                              I guess $onload must be fixed:

                              Code:
                              var cpost=document.location.hash;
                              if(cpost){ 
                              
                              if(cobj = fetch_object(cpost.substring(1,cpost.length)))
                              cobj.scrollIntoView(true);
                              
                              else {
                              cpostno = cpost.substring(5,cpost.length);
                              if(parseInt(cpostno)>0)
                              {document.location.href='showthread.php?p='+cpostno;};
                                    } 
                                       }

                              and when we looks that code, maybe this was fix?

                              Code:
                              var cpost=document.location.hash;
                              if(cpost){ 
                              
                              if(cobj = fetch_object(cpost.substring(1,cpost.length)))
                              [COLOR="red"][B]{[/B][/COLOR]cobj.scrollIntoView(true);[COLOR="red"][B]} <--- ADD this -  {  and  } [/B][/COLOR]
                              
                              else {
                              cpostno = cpost.substring(5,cpost.length);
                              if(parseInt(cpostno)>0)
                              {document.location.href='showthread.php?p='+cpostno;}[COLOR="Red"][B]; <--- REMOVE this[/B][/COLOR]
                                    } 
                                       }
                              I don't know JS well. If someone knows JS better, maybe you have a solution? I cannot try this, so this is my guess, so BACKUP THIS FILE before any changes!!!

                              Comment

                              Working...