Site bug from long time at least 07.01.2011

[Jerry2020]

If you open a topic in the forum, you find:
0){document.location.href='showthread.php?p='+cpos tno;};} }">
After ****** ads and before the topic.
I use firefox.

[khalidomar]

Re: Small bug

Yup, I believe this is a known issue to the admins and mods. I remember someone else raised the same issue before the last crash. I wonder why is it still there?!!

I do have excellent programming knowledge and I'm welling to help the admins if needed to resolve this issue... just let me know

[peremacedonia]

Re: Small bug

Its 2 minutes job only

[khalidomar]

Re: Small bug

Its 2 minutes job only

Yup, that is what i think, but it has been there for almost a year or more! It is part of the culture now

[peremacedonia]

Re: Small bug

Yup, that is what i think, but it has been there for almost a year or more! It is part of the culture now

I dont notice that code anymore.......
no no is still there
however .......

[uttnls]

Site bug from long time at least 07.01.2011

Look on the C lines page you'll see that is an echo probably from PHP.

I saw it for a long time, and not being fixed i want to bring it to your attention.

For example on this page :

http://www.satlover.com/forum/free-cardsharing-servers/37-satlover-servers-28-feb-new-clines-free-for-all-members-update-start-again.html

You can see this chunck of code :

0){document.location.href='showthread.php?p='+cpos tno;};} }">

Like i said it looks to me like a javacode that is after ?>

Or a wrong echo or something, anyway from source code you can figured out more easly, then me seeing only the HTML
output

If you look closely this string apears at thread level on the entire site

[sonc]

Re: Site bug from long time at least 07.01.2011

Its been there a lot longer than that

It was mentioned last August:

http://www.satlover.com/forum/site-bugs-account-issues-and-suggestions/13238-small-bug.html

I don't even notice it any more

[uttnls]

Re: Site bug from long time at least 07.01.2011

Its been there a lot longer than that

It was mentioned last August:

http://www.satlover.com/forum/site-bugs-account-issues-and-suggestions/13238-small-bug.html

I don't even notice it any more

Thanks i've tried to search for "bug" on this thread and i couldn't find anything so i assumed it was not posted before.

It is not a vulnerability but it could get fixed quite easly

[os2222]

Re: Site bug from long time at least 07.01.2011

seems like some thread counter (tno) in javascript as mentioned.
wrong php echo output. shouldnt harm anything but is ugly to watch every time ^^

[uttnls]

Re: Site bug from long time at least 07.01.2011

seems like some thread counter (tno) in javascript as mentioned.
wrong php echo output. shouldnt harm anything but is ugly to watch every time ^^

It is for an websites developers, it won't bother usual users, most of them i bet won't even observe it

Bytheway the problems comes from SEO module, is a common bug in VbSEO 3.3.0

Lots of users complain that after upgrading VbSeo from version 3.2.0 to VbSeo 3.3.0 they encountered this error "0){document.location.href='showthread.php?p='+cpo stno;};} }">".

Also this error is comming in conjunction with use of a custom template, not that provided with vbulletin.

As far i can see satlover uses vbseo 3.3.0 and that's why i'm sure that the error is from there.

Hope this will help in removing the bug

[peremacedonia]

Re: Site bug from long time at least 07.01.2011

It was thread for this last sumer and it isnt fix yet so we need only to ignore thats leters

[pirrup]

Re: Small bug

the bug is still there , just got it after making a new thread

0){document.location.href='showthread.php?p='+cpos tno;};} }">

[enes]

Re: Small bug

Satlover, couple times try to find this extra code, with no luck. Maybe it's 2 minutes job, or couple minutes, but we cannot get access data to server and AdminCP forum to fix it. Maybe Satlover don't have enough time to deal with this?

[uttnls]

Re: Small bug

Is an vbulletin issue in conjunction with SEO module, and is not a problem easy fixable. Please do a ****** search and you'll see what is that about.

Look below, i also merged to threads on same issue and there is an older response of mine

[enes]

Re: Site bug from long time at least 07.01.2011

It is for an websites developers, it won't bother usual users, most of them i bet won't even observe it

Bytheway the problems comes from SEO module, is a common bug in VbSEO 3.3.0

Lots of users complain that after upgrading VbSeo from version 3.2.0 to VbSeo 3.3.0 they encountered this error "0){document.location.href='showthread.php?p='+cpo stno;};} }">".

Also this error is comming in conjunction with use of a custom template, not that provided with vbulletin.

As far i can see satlover uses vbseo 3.3.0 and that's why i'm sure that the error is from there.

Hope this will help in removing the bug

It seems that you're right. This error code is in file:

INCLUDES/functions_vbseo_hook.php

Here is a error code, and now just to find where is a problem.

case 'showthread_complete':
global $onload;
if(!$onload && !strstr($_SERVER['HTTP_REFERER'],$_SERVER['VBSEO_URI']))
{
$onload = "var cpost=document.location.hash;if(cpost){ if(cobj = fetch_object(cpost.substring(1,cpost.length)))cobj.scrollIntoView(true);else {cpostno = cpost.substring(5,cpost.length);if(parseInt(cpostno)>0){document.location.href='showthread.php?p='+cpostno;};} }";
} 

I guess $onload must be fixed:

var cpost=document.location.hash;
if(cpost){ 

if(cobj = fetch_object(cpost.substring(1,cpost.length)))
cobj.scrollIntoView(true);

else {
cpostno = cpost.substring(5,cpost.length);
if(parseInt(cpostno)>0)
{document.location.href='showthread.php?p='+cpostno;};
      } 
         }

and when we looks that code, maybe this was fix?

var cpost=document.location.hash;
if(cpost){ 

if(cobj = fetch_object(cpost.substring(1,cpost.length)))
[COLOR="red"][B]{[/B][/COLOR]cobj.scrollIntoView(true);[COLOR="red"][B]} <--- ADD this -  {  and  } [/B][/COLOR]

else {
cpostno = cpost.substring(5,cpost.length);
if(parseInt(cpostno)>0)
{document.location.href='showthread.php?p='+cpostno;}[COLOR="Red"][B]; <--- REMOVE this[/B][/COLOR]
      } 
         }

I don't know JS well. If someone knows JS better, maybe you have a solution? I cannot try this, so this is my guess, so BACKUP THIS FILE before any changes!!!